fix(dbs-dropdown): make to allow the search in supported db dropdown #19125

prosdev0107 · 2022-03-11T15:01:26Z

SUMMARY

Update Supported Databases Dropdown to Allow Typeahead

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:

AFTER:

TESTING INSTRUCTIONS

How to reproduce bug

Click to the Databases page
Open the + Databases button
Click to type in the dropdown search bar

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

codecov · 2022-03-11T15:40:28Z

Codecov Report

Merging #19125 (5997cf6) into master (7524e1e) will not change coverage.
The diff coverage is n/a.

❗ Current head 5997cf6 differs from pull request most recent head c35d1ca. Consider uploading reports for the commit c35d1ca to get more accurate results

@@           Coverage Diff           @@
##           master   #19125   +/-   ##
=======================================
  Coverage   66.52%   66.52%           
=======================================
  Files        1646     1646           
  Lines       63540    63540           
  Branches     6466     6466           
=======================================
  Hits        42268    42268           
  Misses      19596    19596           
  Partials     1676     1676

Flag	Coverage Δ
javascript	`51.27% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...c/views/CRUD/data/database/DatabaseModal/index.tsx	`32.90% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7524e1e...c35d1ca. Read the comment docs.

rusackas

I was just wishing for this yesterday!!! What a simple yet impactful change. Thanks for the thorough PR description, too!

…19125) (cherry picked from commit 8e7af79)

fix(dbs-dropdown): make to allow the search in supported db dropdown

c35d1ca

pull-request-size bot added the size/XS label Mar 11, 2022

diegomedina248 approved these changes Mar 11, 2022

View reviewed changes

rusackas approved these changes Mar 11, 2022

View reviewed changes

rusackas merged commit 8e7af79 into apache:master Mar 16, 2022

villebro added the lts-v1 label Mar 29, 2022

villebro pushed a commit that referenced this pull request Apr 3, 2022

fix(dbs-dropdown): make to allow the search in supported db dropdown (#…

a0138af

…19125) (cherry picked from commit 8e7af79)

mistercrunch added 🍒 1.5.0 🍒 1.5.1 🍒 1.5.2 🍒 1.5.3 🚢 2.0.1 labels Feb 18, 2024

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 and removed 🚢 2.0.1 labels Mar 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(dbs-dropdown): make to allow the search in supported db dropdown #19125

fix(dbs-dropdown): make to allow the search in supported db dropdown #19125

prosdev0107 commented Mar 11, 2022 •

edited

Loading

codecov bot commented Mar 11, 2022

rusackas left a comment

fix(dbs-dropdown): make to allow the search in supported db dropdown #19125

fix(dbs-dropdown): make to allow the search in supported db dropdown #19125

Conversation

prosdev0107 commented Mar 11, 2022 • edited Loading

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

codecov bot commented Mar 11, 2022

Codecov Report

rusackas left a comment

Choose a reason for hiding this comment

prosdev0107 commented Mar 11, 2022 •

edited

Loading